refactor: api event naming conventions #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daanvdplas <daanvdplas@live.nl>
…runtime_versioning
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## daan/api #286 +/- ##
=========================================
Coverage 51.03% 51.03%
=========================================
Files 47 47
Lines 4701 4701
Branches 4701 4701
=========================================
Hits 2399 2399
Misses 2254 2254
Partials 48 48
|
Daanvdplas
approved these changes
Sep 13, 2024
Daanvdplas
force-pushed
the
chungquantin/refactor-pallet_api_events
branch
from
4e22223
to
3df17e1
Compare
evilrobot-01
approved these changes
Sep 13, 2024
peterwht
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the pallet API event to follow the conventional passive tense.